Homework D

This commit is contained in:
Carlos Galindo 2020-01-15 22:39:17 +01:00
parent f857a60a28
commit 1bccb801ee
Signed by: kauron
GPG key ID: 83E68706DEE119A3
3 changed files with 47 additions and 0 deletions

1
HWD/Grade.txt Normal file
View file

@ -0,0 +1 @@
Grade: 10/10

23
HWD/nop90_report.txt Normal file
View file

@ -0,0 +1,23 @@
Notes from code review of KaiJa=========================================
-Supernova: some names are undescriptive
-Supernova: unnecessary == true
-Supernova: nested statements instead of combined conditions
-cesil: debug prints not removed
-teamasdf: access static constants from instance object
-Supernova: newArray, with size 0 it exits with an error, and wrong exit code
-Supernova: missing null-pointer checks (method calls)
-Supernova: binaryOp, modulo operator unimplented, and no default case
-Supernova: var, Kind converted to string to compare
-Supernova: casting arrays generates uncompilable assembly code
-cesil: unnecessary casts to Expr

23
HWD/report.txt Normal file
View file

@ -0,0 +1,23 @@
Notes from code review of KaiJa=========================================
-Supernova: some names are undescriptive
-Supernova: unnecessary == true
-Supernova: nested statements instead of combined conditions
-cesil: debug prints not removed
-teamasdf: access static constants from instance object
-Supernova: newArray, with size 0 it exits with an error, and wrong exit code
-Supernova: missing null-pointer checks (method calls)
-Supernova: binaryOp, modulo operator unimplented, and no default case
-Supernova: var, Kind converted to string to compare
-Supernova: casting arrays generates uncompilable assembly code
-cesil: unnecessary casts to Expr