From 1bccb801ee3cdac7780919d4437fec98257143eb Mon Sep 17 00:00:00 2001 From: Carlos Galindo Date: Wed, 15 Jan 2020 22:39:17 +0100 Subject: [PATCH] Homework D --- HWD/Grade.txt | 1 + HWD/nop90_report.txt | 23 +++++++++++++++++++++++ HWD/report.txt | 23 +++++++++++++++++++++++ 3 files changed, 47 insertions(+) create mode 100644 HWD/Grade.txt create mode 100644 HWD/nop90_report.txt create mode 100644 HWD/report.txt diff --git a/HWD/Grade.txt b/HWD/Grade.txt new file mode 100644 index 0000000..baf469f --- /dev/null +++ b/HWD/Grade.txt @@ -0,0 +1 @@ +Grade: 10/10 \ No newline at end of file diff --git a/HWD/nop90_report.txt b/HWD/nop90_report.txt new file mode 100644 index 0000000..408f8ca --- /dev/null +++ b/HWD/nop90_report.txt @@ -0,0 +1,23 @@ +Notes from code review of KaiJa========================================= + + +-Supernova: some names are undescriptive +-Supernova: unnecessary == true + +-Supernova: nested statements instead of combined conditions + +-cesil: debug prints not removed + +-teamasdf: access static constants from instance object + +-Supernova: newArray, with size 0 it exits with an error, and wrong exit code + +-Supernova: missing null-pointer checks (method calls) + +-Supernova: binaryOp, modulo operator unimplented, and no default case + +-Supernova: var, Kind converted to string to compare + +-Supernova: casting arrays generates uncompilable assembly code + +-cesil: unnecessary casts to Expr diff --git a/HWD/report.txt b/HWD/report.txt new file mode 100644 index 0000000..408f8ca --- /dev/null +++ b/HWD/report.txt @@ -0,0 +1,23 @@ +Notes from code review of KaiJa========================================= + + +-Supernova: some names are undescriptive +-Supernova: unnecessary == true + +-Supernova: nested statements instead of combined conditions + +-cesil: debug prints not removed + +-teamasdf: access static constants from instance object + +-Supernova: newArray, with size 0 it exits with an error, and wrong exit code + +-Supernova: missing null-pointer checks (method calls) + +-Supernova: binaryOp, modulo operator unimplented, and no default case + +-Supernova: var, Kind converted to string to compare + +-Supernova: casting arrays generates uncompilable assembly code + +-cesil: unnecessary casts to Expr