From f857a60a282d92498bc27a4458fa000dfcf21fdf Mon Sep 17 00:00:00 2001 From: Carlos Galindo Date: Wed, 15 Jan 2020 22:39:02 +0100 Subject: [PATCH] Homework C --- HWC/Grade.txt | 1 + HWC/report.txt | 22 ++++++++++++++++++++++ 2 files changed, 23 insertions(+) create mode 100644 HWC/Grade.txt create mode 100644 HWC/report.txt diff --git a/HWC/Grade.txt b/HWC/Grade.txt new file mode 100644 index 0000000..baf469f --- /dev/null +++ b/HWC/Grade.txt @@ -0,0 +1 @@ +Grade: 10/10 \ No newline at end of file diff --git a/HWC/report.txt b/HWC/report.txt new file mode 100644 index 0000000..f28eefa --- /dev/null +++ b/HWC/report.txt @@ -0,0 +1,22 @@ +Notes from code review of teamasdf +========================================= + +To simplify this summary, the remarks said by other groups will be prefixed with "-", and the responses from teamasdf with "*" + +Most problems have been noted by teamasdf in their presentation of their code. + +- Usage of emitRaw instead of emit or emitMove (intermittent) +* The coding style changed along the project, and for ditions we forgot to use the proper methods +- There is an empty if somewhere +* Legacy from now removed print statements +- Unnecessary comments containing just code (such as the block comment in builtInRead) +* Again legacy code that should have been deleted +- Some minor things: unused variable in unaryOp and the missing @Override +- In the register counter visitor, the overriding of methods with the same method body as the super-method is not a good practice. +* Noted during the presentation +- The stack alignment in methodDecl that may have been necessary when a bug was present is not necessary once fixed +- Some labels are unused +- The emitRaw statements are copied from a compiled example program and is thus not as easy to read (but may be more efficient) +- The RegisterCountVisitor is located in cd.ir instead of cd.backend.codegen +- The RegisterCountVisitor could have extended ExprVisitor instead of ExprVisitor and having a type parameter. +