24 lines
662 B
Text
24 lines
662 B
Text
|
Notes from code review of KaiJa=========================================
|
||
|
|
|
||
|
|
|
||
|
|
-Supernova: some names are undescriptive
|
||
|
|
-Supernova: unnecessary == true
|
||
|
|
|
||
|
|
-Supernova: nested statements instead of combined conditions
|
||
|
|
|
||
|
|
-cesil: debug prints not removed
|
||
|
|
|
||
|
|
-teamasdf: access static constants from instance object
|
||
|
|
|
||
|
|
-Supernova: newArray, with size 0 it exits with an error, and wrong exit code
|
||
|
|
|
||
|
|
-Supernova: missing null-pointer checks (method calls)
|
||
|
|
|
||
|
|
-Supernova: binaryOp, modulo operator unimplented, and no default case
|
||
|
|
|
||
|
|
-Supernova: var, Kind converted to string to compare
|
||
|
|
|
||
|
|
-Supernova: casting arrays generates uncompilable assembly code
|
||
|
|
|
||
|
|
-cesil: unnecessary casts to Expr
|